All files for SparkFun LumiDrive and Redboard Turbo #1506
Merged
Conversation
…parkFun LumiDrive and Redboard Turbo
tannewt
requested changes
Jan 30, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Yay! Thank you for the PR. You'll want to add the board names to the list in .travis.yml. That way they will always be built and released. Add it to the second list since it's the fastest to build currently: https://github.com/adafruit/circuitpython/blob/master/.travis.yml#L25
Author
|
Added our boards to the travis.yml and removed the extraneous comments. |
tannewt
approved these changes
Jan 31, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the new boards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's two commits here. The first one adds config files to the atmel-samd boards file for the SparkFun LumiDrive and Redboard Turbo. The other commit adds the hardware profile of the flash chip used on these boards to devices.h. Let me know if you want me to split these commits and/or whatever else you need for a smooth merge.
Thanks!